That tomcat AJP port property... #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked in code that will support container-specific properties. There was actually far more that needed to be refactored than I thought. Please build the plugin from source and try if it works for you set the AJP port. I'd release a new version based on your feedback. |
|
Copy that -- will do. I'll report back as soon as I have something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Benjamin,
This is a quick and dirty hack to get the Tomcat AJP Port property on Cargo exposed for use in Gradle. I've almost certainly done it the Wrong Way™, and I expect you'll refactor it out anyway if you're adding container-specific closure goodness to the plugin.
Best wishes,
Dave Williams @ Asdeq Labs