Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to tag a docker build with multiple tags #286

Closed
MarkRx opened this issue Oct 3, 2016 · 4 comments
Closed

Ability to tag a docker build with multiple tags #286

MarkRx opened this issue Oct 3, 2016 · 4 comments
Assignees
@orzeh
Labels
enhancement

Comments

@MarkRx
Copy link
Contributor

MarkRx commented Oct 3, 2016

Docker 1.10 added the ability to tag a build with multiple tags. Doing so is convenient as it reduces the number of tasks needed in a project (for example when building and using both "latest" and "" tags)

It would be nice if the plugin could support this. For docker 1.10+ it would just use the multi-tag approach. For docker < 1.10 it could run the build step then run a series of Actions afterwards that tag the image behind the scenes.
@orzeh orzeh self-assigned this Oct 4, 2016
@orzeh
Copy link
Collaborator

orzeh commented Oct 4, 2016

I would be a nice feature. To add it we must check if docker-java supports this already. IMO it should work only for docker 1.10+, for earlier version it should throw exception.

Are you interested in submitting PR?

@orzeh
Copy link
Collaborator

orzeh commented Oct 4, 2016

docker-java doesn't support this yet. We must wait for them to implement this.
I saw you opened issue there, so we should stay tuned.

@MarkRx MarkRx mentioned this issue Oct 4, 2016
Closed
@orzeh orzeh mentioned this issue Dec 28, 2016
Closed
@cdancy
Copy link
Collaborator

cdancy commented May 14, 2017

@orzeh I believe knocked this out for the docker-java project already? Would this be an easy PR to put together to take advantage of this functionality?

@orzeh
Copy link
Collaborator

orzeh commented May 14, 2017

@cdancy yes, I'll do this after docker-java release

orzeh pushed a commit that referenced this issue May 18, 2017
Allow to build image with multiple tags
0b8d62b 
Adds tags property to DockerBuildImage task and deprecates tag.
To preserve backward compatibility if tag is defined, tags are ignored.
Fix #286
@orzeh orzeh mentioned this issue May 18, 2017
Merged
cdancy pushed a commit that referenced this issue May 19, 2017
@cdancy
Allow to build image with multiple tags (#380)
9b0dce4 
Adds tags property to DockerBuildImage task and deprecates tag.
To preserve backward compatibility if tag is defined, tags are ignored.
Fix #286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orzeh orzeh

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdancy @orzeh @MarkRx