Allow to build image with multiple tags #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tags property to DockerBuildImage task and deprecates tag. To preserve backward compatibility if tag is defined, tags are ignored. Fix #286
cdancy
reviewed
May 18, 2017
| private String imageCreation() { | ||
| """ | ||
| import com.bmuschko.gradle.docker.tasks.image.Dockerfile | ||
| import com.bmuschko.gradle.docker.tasks.image.DockerBuildImage | ||
|
|
||
| task dockerfile(type: Dockerfile) { | ||
| from 'ubuntu:12.04' | ||
| from 'alpine' |
cdancy
reviewed
May 18, 2017
| } else if (getTags()) { | ||
| def tagListString = getTags().collect {"'${it}'"}.join(", ") | ||
| logger.quiet "Using tags ${tagListString} for image." | ||
| buildImageCmd.withTags(getTags()) |
There was a problem hiding this comment.
Can we allow for both? Maybe something like:
def allTags = [] + getTags()
if (getTag()) { allTags << getTag() }
if (allTags) {
def tagListString = allTags.collect {"'${it}'"}.join(", ")
logger.quiet "Using tags ${tagListString} for image."
buildImageCmd.withTags(allTags)
}
May be a better more succinct way to write this but I can def see folks defining a default tag and then possibly through a doFirst block add additional tags at runtime.
cdancy
reviewed
May 19, 2017
|
I take that back. Doing so is going to promote bad behavior and force us to maintain both ways for longer than is necessary. Merging now. |
Exactly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
tagsproperty toDockerBuildImagetask and deprecatestagproperty.To preserve backward compatibility if
tagis defined,tagsare ignored.Fix #286