Fix shading of Docker Java and its transitive dependencies #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looked like there were still packages from |
|
I looked at the commit history and it looks like the Docker Java package itself was never relocated. I was 100% convinced it was the case but it doesn't seem to have been the case. |
bmuschko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick look through the packaged jar shows that
com.github.dockerjavais still in the root directory. If we relocate this package, other plugins pulling in that library should work.I've also excluded slf4j from the shaded configuration since that will be pulled in from other plugins, but replaced by gradle at runtime.
The producer #954 (comment) in Intellij shows two classes loaded in the same location.
