Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to Grails-3.0.2 #52

Merged
merged 34 commits into from Jun 30, 2015
Merged

Migrated to Grails-3.0.2 #52

merged 34 commits into from Jun 30, 2015

Conversation

mansi90
Copy link
Contributor

@mansi90 mansi90 commented Jun 27, 2015

No description provided.

mansiarora and others added 30 commits June 27, 2015 11:10
@aruizca
Copy link
Collaborator

aruizca commented Jun 27, 2015

Hi @mansi90
Thanks for your contribution. I will review the PR and release. TBH I have not released a Grails 3 plugin yet, so I have to get familiarized with it first.

@TestMixin(GroovyPageUnitTestMixin)
@TestFor(GoogleVisualizationTagLib)
class GoogleVisualizationTagLibTests {
void testPieChart() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this test removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases are not removed, they are migrated to spock test cases, you can check the same spec file by name GoogleVisualizationTagLibSpec.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! :-) 👍

@aruizca aruizca self-assigned this Jun 27, 2015
@aruizca aruizca added this to the v2.0 milestone Jun 27, 2015
aruizca added a commit that referenced this pull request Jun 30, 2015
Migrated to Grails-3.0.2
@aruizca aruizca merged commit df241de into bmuschko:master Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants