Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emma crashes when no map files were found #68

Closed
holzkohlengrill opened this issue Jun 9, 2020 · 0 comments
Closed

Emma crashes when no map files were found #68

holzkohlengrill opened this issue Jun 9, 2020 · 0 comments
Assignees
Labels
bug Something isn't working emma Related to Emma component high prio This issue shall be prioritised SP: 1
Projects
Milestone

Comments

@holzkohlengrill
Copy link
Collaborator

holzkohlengrill commented Jun 9, 2020

Description

Emma crashes when no map files were found:

        (info) : Started processing at 13:02:25
        (info) : Imported 1 global config entries:['MCU']
        (info) : Processing the mapfiles of the configID "MCU"
     (warning) : No file found for  MCU_Application      (pattern: \bApplicationHud\.map ); skipping...
     (warning) : No file found for  MCU_Bootloader       (pattern: \bBootloaderHud\.map ); skipping...
     (warning) : No mapfiles found for configID: "MCU"!
     (warning) : The specificConfiguration of the configId "MCU" is invalid!
The configId "MCU" will not be analysed!
Traceback (most recent call last):
  File "C:/0-repos/Emma/Emma/emma.py", line 225, in <module>
    runEmma()
  File "C:/0-repos/Emma/Emma/emma.py", line 221, in runEmma
    main(parsedArguments)
  File "C:/0-repos/Emma/Emma/emma.py", line 54, in main
    memoryManager.createReports(arguments.memVis, arguments.memVisResolved, arguments.noprompt)
  File "C:\0-repos\Emma\Emma\emma_libs\memoryManager.py", line 373, in createReports
    createTeamScaleReports()
  File "C:\0-repos\Emma\Emma\emma_libs\memoryManager.py", line 363, in createTeamScaleReports
    for memEntryRow in consumerCollections["Section_Summary"]:
KeyError: 'Section_Summary'

Process finished with exit code 1

It seems that when no analysis is happening Emma tries to create the reports ... anyway.

  • Check if there is a functional test which runs Emma without map files.
  • Add new tests if this is not present

Steps to reproduce

Branch: 19-graphics
One configID with no map files found (but configured).

@holzkohlengrill holzkohlengrill added bug Something isn't working high prio This issue shall be prioritised emma Related to Emma component SP: 1 labels Jun 9, 2020
@holzkohlengrill holzkohlengrill added this to the 3.3 milestone Jun 9, 2020
@holzkohlengrill holzkohlengrill added this to In progress in Planning Jun 9, 2020
@DariaPigasova DariaPigasova moved this from In progress to Review in progress in Planning Jun 10, 2020
Planning automation moved this from Review in progress to Done Dec 16, 2020
heliocastro pushed a commit that referenced this issue Mar 7, 2022
…erated (#75)

* close #68, added error message when no mapfiles were found
* error message replaced by a warning
* added unit tests for configuration.py

Co-authored-by: Marcel Schmalzl <holzkohlengrill@gmail.com>
Co-authored-by: Marcel Schmalzl <12732886+holzkohlengrill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working emma Related to Emma component high prio This issue shall be prioritised SP: 1
Projects
Planning
  
Done
Development

No branches or pull requests

2 participants