Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R] Add BEP10: Add source of transactions #10

Merged
merged 8 commits into from
Jun 6, 2019
Merged

Conversation

chainwhisper
Copy link
Contributor

@chainwhisper chainwhisper commented May 28, 2019

BEP-10: Registered Types for Transaction Source

1. Summary

This BEP describes how to have a better understanding of the origin of a transaction with a special field in a transaction for recording its source.

2. Abstract

By adding a field in each transaction message, the origin of any transaction could be tracked.

3. Status

This BEP is WIP.

4. Motivation

Binance Chain is designed to connect with multiple service providers, and each provider is incentivized to broadcast more transactions. This proposal does not want to deal with assigning the values for various source types. The different sources will claim different value and such a proposition will be assigned afterwards.

5. Specification

5.1 Transaction Data Structure

The transaction is a standard way to wrap a message with signatures.

Field Type Description
Msgs message transaction message
Sig signature signatures from the account holder
Memo string some notes come with the transaction
Source int64 where does this transaction come from
Data byte[] transaction data

5.2 Register Process

  • Service Provider proposes to add a source type
  • Maintainer review the proposal
  • If the proposal gets accepted, this new type will be recorded.

5.3 Registered Source types

These are the registered source types.

All of these constant values shall be considered hardcoded in client implementations.

Identifier Source Description
0 Binance Chain Command Line
1 Binance DEX Web Wallet
2 Trust Wallet

6. License

The content is licensed under CC0.

@chainwhisper chainwhisper changed the title Add BEP10: Add source of transactions [R4R] Add BEP10: Add source of transactions May 28, 2019
BEP10.md Outdated


| Identifier | Symbol | Source |
| ---------- | ---------------------------- | ---------- |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to declear 0 stands for no source, in case later register

BEP10.md Outdated

| Identifier | Symbol | Source |
| ---------- | ---------------------------- | ---------- |
| 1 | DEX CLI | Desktop |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we do not specify source in our released binaries.

@canyateam
Copy link
Contributor

The CanYa Community nominate the following Source Identifiers:

CanWork.io Decentralised Serviceplace App

Users process transactions between themselves in the payments of services.

Identifier: 3
Source Code: https://github.com/canyacoin/canwork-web-ui

CanYaDAO Decentralised Autonomous Organisation

Members stake assets, distribute DAO assets and govern the CanYa ecosystem.

Identifier: 4
Source Code: https://github.com/canyacoin/canyadao

@darren-liu darren-liu merged commit d7b2603 into master Jun 6, 2019
IntegralTeam added a commit to IntegralTeam/BEPs that referenced this pull request Jul 10, 2019
This change propose to claim bnb-chain#10 for Equal Wallet.
@IntegralTeam IntegralTeam mentioned this pull request Jul 10, 2019
Equal-Network added a commit to Equal-Network/BEPs that referenced this pull request Jul 10, 2019
PR to claim bnb-chain#10 for Equal Wallet.
@Equal-Network Equal-Network mentioned this pull request Jul 10, 2019
@brilliant-lx brilliant-lx mentioned this pull request Dec 2, 2022
Copy link

@jonesk7734 jonesk7734 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants