Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: place the upgrade check in right place #327

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

unclezoro
Copy link
Collaborator

Description

Currently the BEP159 upgrade check is placed in the validateBasic function which is stateless and dont have the context about block height, it will cause the wrong check on cmd and SDK.

Rationale

We move the check to the handler instead of validateBasic.

It wont impact the on-chain logic and will not cause hardfork.

Example

No

@codecov-commenter
Copy link

Codecov Report

Merging #327 (ac45b2e) into master (0211967) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   46.80%   46.79%   -0.01%     
==========================================
  Files         247      247              
  Lines       23732    23735       +3     
==========================================
  Hits        11107    11107              
- Misses      11959    11962       +3     
  Partials      666      666              

@unclezoro unclezoro merged commit d3ff7da into bnb-chain:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants