Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast finality #334

Closed
wants to merge 9 commits into from
Closed

Fast finality #334

wants to merge 9 commits into from

Conversation

NathanBSC
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

Codecov Report

Merging #334 (6b53772) into develop (23ab621) will decrease coverage by 0.58%.
The diff coverage is 1.17%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #334      +/-   ##
===========================================
- Coverage    46.72%   46.14%   -0.58%     
===========================================
  Files          247      248       +1     
  Lines        23829    24087     +258     
===========================================
- Hits         11133    11114      -19     
- Misses       12029    12307     +278     
+ Partials       667      666       -1     

@NathanBSC NathanBSC closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants