fix: prevent outOfGas issue #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
approved these changes
Mar 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
* fix: prevent outOfGas issue (#525) * chore: update redelegate fee rate base to 100000 (#530) * chore: update BC-fusion mainnet init settings * chore: lint contract and fix workflow (#537) * chore: fix typo in generate.py * chore: fix unit tests * chore: remove init call in unit tests after bc-fusion (#563) --------- Co-authored-by: zjubfd <296179868@qq.com> Co-authored-by: Roshan <48975233+Pythonberg1997@users.noreply.github.com> Co-authored-by: Roshan <luoshen1997@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to fix an issue in
exitMaintenancemethod.Changes
There is a try catch wrap the
downtimeSlashcontract call, it is possible thatdowntimeSlashout of gas, while there is still 1/16 of total gas left to finish the post execution. This PR is to prevent this from happening by adding more gas cost in the post execution.Notable changes: