all: sync with upstream #1138
Merged
all: sync with upstream #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR significantly reduces the memory consumption of a long reorg
core/vm: optimize PUSH opcode discrimination
Move locking into trieDB insert function
* eth/filters: fix pending for getLogs * add pending method to test backend * fix block range validation
accounts/url: add test logic what check null string to parseURL()
* common: improve pretty duration regex * common: improve pretty duration regex
| @@ -76,7 +76,7 @@ func codeBitmapInternal(code, bits bitvec) bitvec { | |||
| for pc := uint64(0); pc < uint64(len(code)); { | |||
| op := OpCode(code[pc]) | |||
| pc++ | |||
| if op < PUSH1 || op > PUSH32 { | |||
| if int8(op) < int8(PUSH1) { // If not PUSH (the int8(op) > int(PUSH32) is always false). | |||
There was a problem hiding this comment.
If not PUSH (the int8(op) > int(PUSH32) is always false)
why?
There was a problem hiding this comment.
The opcode of "PUSH1" is "0x60", and all the other PUSH opcodes have a greater opCode than "PUSH1". An opcode that is less than "0x60" can never be a "PUSH32" .
There was a problem hiding this comment.
but op > PUSH32 could be true, right? say if op is Dup1(0x80), while PUSH32 is 0x7f.
unclezoro
approved these changes
Oct 25, 2022
|
Yes. You are right.
After realizing that I was wrong about this, I did a little search on this.
I found this function is primarily used for tests. And they never use an opcode greater than PUSH32 in their test cases:
https://github.com/ethereum/go-ethereum/blob/master/core/vm/analysis_test.go#L32
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Larry ***@***.***>
Sent: Wednesday, October 26, 2022 12:06:01 PM
To: bnb-chain/bsc ***@***.***>
Cc: junnmm ***@***.***>; Comment ***@***.***>
Subject: Re: [bnb-chain/bsc] all: sync with upstream (PR #1138)
@brilliant-lx commented on this pull request.
________________________________
In core/vm/analysis.go<#1138 (comment)>:
@@ -76,7 +76,7 @@ func codeBitmapInternal(code, bits bitvec) bitvec {
for pc := uint64(0); pc < uint64(len(code)); {
op := OpCode(code[pc])
pc++
- if op < PUSH1 || op > PUSH32 {
+ if int8(op) < int8(PUSH1) { // If not PUSH (the int8(op) > int(PUSH32) is always false).
but op > PUSH32 could be true right, say if op is Dup1(0x80)
—
Reply to this email directly, view it on GitHub<#1138 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWVO35TLUFHCX2IMPH22CJTWFCU2TANCNFSM6AAAAAARGMMC5E>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Oh, I think I got.
It is not a bug introduced in benchmark.
0x80 is negative as a signed integer.
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: junnm na ***@***.***>
Sent: Wednesday, October 26, 2022 8:22:23 PM
To: bnb-chain/bsc ***@***.***>; bnb-chain/bsc ***@***.***>
Cc: Comment ***@***.***>
Subject: Re: [bnb-chain/bsc] all: sync with upstream (PR #1138)
Yes. You are right.
After realizing that I was wrong about this, I did a little search on this.
I found this function is primarily used for tests. And they never use an opcode greater than PUSH32 in their test cases:
https://github.com/ethereum/go-ethereum/blob/master/core/vm/analysis_test.go#L32
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Larry ***@***.***>
Sent: Wednesday, October 26, 2022 12:06:01 PM
To: bnb-chain/bsc ***@***.***>
Cc: junnmm ***@***.***>; Comment ***@***.***>
Subject: Re: [bnb-chain/bsc] all: sync with upstream (PR #1138)
@brilliant-lx commented on this pull request.
________________________________
In core/vm/analysis.go<#1138 (comment)>:
@@ -76,7 +76,7 @@ func codeBitmapInternal(code, bits bitvec) bitvec {
for pc := uint64(0); pc < uint64(len(code)); {
op := OpCode(code[pc])
pc++
- if op < PUSH1 || op > PUSH32 {
+ if int8(op) < int8(PUSH1) { // If not PUSH (the int8(op) > int(PUSH32) is always false).
but op > PUSH32 could be true right, say if op is Dup1(0x80)
—
Reply to this email directly, view it on GitHub<#1138 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWVO35TLUFHCX2IMPH22CJTWFCU2TANCNFSM6AAAAAARGMMC5E>.
You are receiving this because you commented.Message ID: ***@***.***>
|
setunapo
approved these changes
Oct 27, 2022
brilliant-lx
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sync with
go-ethereum 1.10.19:mainly including some bug fixes, and together with some separate
prs: #1139, #1140, #1141.Rationale
N/A
Example
N/A
Changes
Notable changes:
N/A