Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: prefer new(big.Int) over big.NewInt(0) #1141

Merged
merged 1 commit into from
Oct 28, 2022
Merged

all: prefer new(big.Int) over big.NewInt(0) #1141

merged 1 commit into from
Oct 28, 2022

Conversation

qinglin89
Copy link
Contributor

@qinglin89 qinglin89 commented Oct 16, 2022 •
edited
Loading

Description

Sync with go-ethereum:

minor performance improvement: big.NewInt(0).Xxx -> new(big.Int).Xxx

Rationale

N/A

Example

N/A

Changes

N/A

@lmittmann @qinglin89
all: prefer new(big.Int) over big.NewInt(0) (#25087)
496f5b3 
minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx`
@qinglin89 qinglin89 mentioned this pull request Oct 20, 2022
Merged
@brilliant-lx brilliant-lx merged commit 2003d54 into bnb-chain:develop Oct 28, 2022
@qinglin89 qinglin89 mentioned this pull request Nov 1, 2022
Merged
@unclezoro unclezoro mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@brilliant-lx brilliant-lx brilliant-lx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qinglin89 @unclezoro @brilliant-lx @lmittmann