Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change default rcmgr limit to no infinite #279

Merged
merged 1 commit into from
Apr 6, 2023
Merged

chore: change default rcmgr limit to no infinite #279

merged 1 commit into from
Apr 6, 2023

Conversation

joeylichang
Copy link
Contributor

Description

Change default rcmgr limit to no infinite.
in docker env, get the docker limits need permission, not universal, so only supports rcmgr limits config.

Rationale

N/A

Example

N/A

Changes

Notable changes:

N/A

@joeylichang joeylichang added the r4r Ready for review label Apr 5, 2023
sysvm
sysvm approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeylichang joeylichang merged commit a8fd785 into develop Apr 6, 2023
@joeylichang joeylichang deleted the fix-rcmgr-limits branch April 6, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysvm sysvm sysvm approved these changes

@will-2012 will-2012 will-2012 approved these changes

Assignees
No one assigned
Labels
r4r Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joeylichang @sysvm @will-2012