Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-node/op-batcher): fallbackClient should ignore ethereum.NotFound error #94

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

welkin22
Copy link
Contributor

Description

fallbackClient ignores ethereum.NotFound errors when counting errors during error handling, as this error does not indicate any issues with the endpoint's health.
The fallbackClient in op-node and op-batcher was modified. Due to the multiple rpc methods in fallbackClient in op-batcher, it can be difficult to troubleshoot issues. Therefore, some new logs were added to facilitate future troubleshooting.

Rationale

We found that the fallbackClient in op-batcher always inexplicably switches endpoints, although no request error was found in the log. After investigation, it was found that the ethereum.NotFound error returned by the interface when op-batcher obtained the TransactionReceipt was counted by the fallbackClient.

Example

none

Changes

Notable changes:

  • In both op-node and op-batcher, the fallbackClient ignores the ethereum.NotFound error.
  • Add logs to fallbackClient in op-batcher for easier troubleshooting in the future.

Copy link
Contributor

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@welkin22 welkin22 merged commit 3711711 into bnb-chain:develop Dec 12, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants