Add link to twilight theme #52
Conversation
|
Could you please add a description of why you think hyperterm-twilight is an awesome theme? Just asking, as |
|
To pull description you mean? |
|
Cause I added one in the readme |
|
@markelog Yes, to the PR. Thanks 😄 |
|
Done |
|
Hey @markelog, could you please move it to the bottom of the list? Thanks |
|
Done, btw, I would recommend put those requirements both about content of the pull description and specifics of adding new themes at the bottom to your github template |
@bnb not really, it says
For me it implies putting description in the README, not in pull request, I don't really understand why you want it in the description. I think that is the reason why you found yourself repeating phrase
Although recently, you stop asking for that, so I really not sure whats what now. It seems because of that you can't land simple doc one-liner in 10 days :/ |
|
@markelog No, I've not landed a doc one-liner because I started a new job and had to go to a Node conference for my new job, and got sick at that conference. It looks like the longest time I went without committing was from the 23rd to the 29th: bnb/awesome-hyperterm commits. Since the 29th, I'm really happy to say we've landed several one-liners! I don't ask for that on every commit by hand - if the description describes the package well enough beyond generic text, I'll accept it. Looks like that didn't happen for the Since I've been slightly more busy, I asked in the Zeit Community slack if anyone would be willing to assist me in maintaining With With Also, I've gone through and updated the PR template somewhat significantly in 04277f9 - please feel free open an issue and let me know if you have any further comments on it! Thanks for all your feedback - I appreciate it. |
|
Thank you for the thoughtful response, I think you doing fine, just sometimes a bit slower then expected. To note - i'm not like accusing you or something of the sort, we all have jobs and personal live... good move to ask for help (thank you @matheuss) if landing process is not fully established it is okay for "fresh" repo in my book. As I understand, pull description didn't needed description of the theme? I had it in readme from the first commit to this pull. So, right now, i'm not sure what else can i do to land this |
|
If you have a rebase issues, i can help there as well... |
|
@markelog Thanks for the feedback. The README.md description is more what we're looking for. What you have is strictly a definition of the theme - it's based on another theme, adapted to terminal usage. What we're looking for is more along the lines of answering the question "Why should I click through to npm for this theme?" for a person looking through awesome-hyperterm. Personally, I've actually never heard of Twilight - or, if I have, I'm not making the connection. That's not ideal for people browsing the list, as it's just noise. We want to bypass that and give them a reason to click through to your theme, if that reason is personally compelling. |
|
I don't what to tell ya, like i don't know any of those themes you have in project, maybe i did encountered them at some of time, but why would i remember them if i don't use them? Twilight is relatively known, it is very old and ported to most of the editors out there. I'm not sure how stuff like
Pops more then i wrote over here. Look at the timeline this is past ridiculous, for two weeks we are talking about this, I contributed in awesome lists couple times before and never seen so much subjectivity and never spend so much time talking about this. Like contributor usually spend day with list like this or two at best if project is maintained that is. I'm really tired of this discussion. Either land it or reject it |
|
Closing - description does not meet this awesome list's standards. |
Port of the awesome Twilight theme, optimized for terminal usage
Checklist: