Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 227 #257

Closed
wants to merge 7 commits into from
Closed

Fix 227 #257

wants to merge 7 commits into from

Conversation

devashish-gaikwad
Copy link

I have added a new feature "--trusted-host" which disables the SSL verification of the requests sent by requests.get function call.

        --trusted-host        Ignore SSL warnings, recommended using with
                              enterprise proxy.

Currently trying to fix pypy and flake8 build problems

@devashish-gaikwad
Copy link
Author

devashish-gaikwad commented May 13, 2021

Hi @alan-barzilay !

The build for Pypy seems to fail not because of the source code but because of some problem with the environment
Check out this build log: https://travis-ci.org/github/bndr/pipreqs/jobs/771058058

Could not build wheels for cryptography which use PEP 517 and cannot be installed directly
The command "pip install coverage coveralls tox" failed and exited with 1 during .

What do you think ?

Possible solution ?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 71.542% when pulling 7e23be2 on devashish-gaikwad:ssl into 90102ac on bndr:master.

@alan-barzilay
Copy link
Collaborator

alan-barzilay commented May 15, 2021

Hi @devashish-gaikwad, thank you for your PR! I will have to brush-up on SSL to understand if this is the best approach so it may take some time before I can get back to you. I would also probably need some sort of test for this PR, but to be honest I'm not sure how to implement a test involving a proxy in travis.
In the mean time, you should rebase this PR onto the next branch where we are focusing development. The pypy issue is also solved there :)

Also, please squash all your commits into one

@devashish-gaikwad
Copy link
Author

Hi Alan! Thanks for the advice, I'll probably close this PR and open a new one with squashed commits. ( I don't really know how to rebase a PR from one place to another, I'll also look for a travis compatible testing way for proxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants