Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maven] Inconsisitent behavior for bndrun between Eclipse Bndtools integration and console #5982

Closed
maho7791 opened this issue Jan 22, 2024 · 5 comments
Assignees

Comments

@maho7791
Copy link
Contributor

Example Project: https://github.com/geckoprojects-org/org.gecko.playground/tree/bndissue/maven
Branch: bndissue

When I just want to resolve a bndrun using the IDE by pressing the resolve button, I always need the resolve execution in maven.

When I want to start/run bndrun I also need a run execution.

If I have a bndrun that inherits from a parent one, that has already been resolved, from withtin the IDE I also need a resolve execution for that concrete one.

My expectation was to just resolve, what needs to be resolved. This would also belong to the configuration. So like in the provided example, my pom.xml is expected to look like this:

org/org.gecko.playground/blob/bndissue/maven/org.gecko.playground.maven.ds.simple/pom.xml

But this only works in the console, but not in the IDE integration, when I press run:
https://github.com/geckoprojects-org/org.gecko.playground/blob/bndissue/maven/org.gecko.playground.maven.ds.simple/pom.xml

I end up with that:

screenshot-bnd-maven

If you remove the comment in line 33, the application runs fine in the console as well as in the IDE Integration.

Shouldn't this behavior be consistent in the IDE and from Maven CMD. Obviously the expected behavior works in the commmand line. So it seems there is a different configuration expected when using the IDE integration.

@juergen-albert juergen-albert self-assigned this Jan 23, 2024
@juergen-albert
Copy link
Contributor

Source of the issue:

if ((mojoExecution = getBndResolverMojoExecution(maven, projectFacade, bndrunMatchs,

@maho7791
Copy link
Contributor Author

The same problem occurs, when Exporting from the IDE

@maho7791
Copy link
Contributor Author

After thinking about this issue, my conclusion is. It is the best to provide a meaningful error message, e.g. when lauching the bndrun:

error-message-missing-resolver-config

@maho7791
Copy link
Contributor Author

I have a solution, but it conflicts a little bit with the changes of PR #6034

@maho7791
Copy link
Contributor Author

error-message-patch.txt

Here is a patch with the proposed changes

pkriens added a commit that referenced this issue Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants