gradle: Fix bnd extension property lookup for Gradle 2.14 #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle 2.14 has changed the property lookup for ExtensionAware objects like Project. Instead of consulting the ext properties before asking the extension object, it now consults the extension object first. This means that if the extension object implements propertyMissing, it must throw a MissingPropertyException for 'ext' and also look in the ext properties before its own properties to preserve the prior behavior. Fixes #1495 Signed-off-by: BJ Hargrave <bj@bjhargrave.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle 2.14 has changed the property lookup for ExtensionAware objects
like Project. Instead of consulting the ext properties before asking the
extension object, it now consults the extension object first. This means
that if the extension object implements propertyMissing, it must throw
a MissingPropertyException for 'ext' and also look in the ext properties
before its own properties to preserve the prior behavior.
Fixes #1495
See also https://discuss.gradle.org/t/bnd-plugin-broken-in-2-14/17983