Maven Test-Cases header #4216
Merged
Maven Test-Cases header #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of emitting an error message, we should handle empty lists in the sort macros. The uniq macro already handles empty lists. Signed-off-by: BJ Hargrave <bj@bjhargrave.com>
We also make the logger object accessible to subclasses. Signed-off-by: BJ Hargrave <bj@bjhargrave.com>
We also change the check for whether the Test-Cases header is set to use getUnexpanded property since we only need to know that the user has set the header. Signed-off-by: BJ Hargrave <bj@bjhargrave.com>
|
See also #4088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop erroring if sort list is empty. Warn is Test-Cases header is empty for bnd-process-tests.
See #4213.