Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot viewer improvements #4548

Merged
merged 6 commits into from Feb 13, 2021

Conversation

chrisrueger
Copy link
Contributor

@chrisrueger chrisrueger commented Feb 11, 2021

  • added a new tab "About"
  • this tab contains a new section with description and explanation about the tool
  • mention and link the Snapshot Viewer in the bnd manual / resolving chapter ... Not sure this is the ideal place, but since it was about debugging, I think it fits.

Preview:
image

@pkriens
Copy link
Member

pkriens commented Feb 12, 2021

You need to sign the commit ... https://github.com/bndtools/bnd/pull/4548/checks?check_run_id=1882616037

@pkriens
Copy link
Member

pkriens commented Feb 12, 2021

I might be missing something but the information about the environment is static, isn't it? It is not updated by the json file?

@chrisrueger
Copy link
Contributor Author

@pkriens ok I will take care of the signing later.

I might be missing something but the information about the environment is static, isn't it? It is not updated by the json file?

Not sure I follow. What are you referring to? Any sentence which is misleading?

@pkriens
Copy link
Member

pkriens commented Feb 12, 2021

On the About tab you show system info like the amount of free memory, file name, etc. However, as far as I can see this information is static, it does not come from the JSON file?

@chrisrueger
Copy link
Contributor Author

chrisrueger commented Feb 12, 2021

On the About tab you show system info like the amount of free memory, file name, etc. However, as far as I can see this information is static, it does not come from the JSON file?

Ah ok I see. This is just the output of the console command bnd:snapshot. Yes this information is from my system and not from the JSON. I just wanted to show a full example of the output, so that people know what this command outputs. The important thing is the location / path where the snapshot.json file is stored, so that you can upload it in the snapshot viewer.

But I can shorten it if you think this is too much noise.

Base automatically changed from master to main February 12, 2021 16:52
@pkriens
Copy link
Member

pkriens commented Feb 12, 2021

Ok. Leave it as is

Base automatically changed from main to master February 12, 2021 18:21
chrisrueger and others added 6 commits February 12, 2021 19:47
Add description and example instructions.

Signed-off-by: Christoph Rueger <c.rueger@synesty.com>
Signed-off-by: Christoph Rueger <c.rueger@synesty.com>
- alignments
- open bundles tab on file upload

Signed-off-by: Christoph Rueger <c.rueger@synesty.com>
- which was already using in title tag of snapshot viewer page.

Signed-off-by: Christoph Rueger <c.rueger@synesty.com>
Signed-off-by: Christoph Rueger <c.rueger@synesty.com>
Signed-off-by: Christoph Rueger <c.rueger@synesty.com>
@pkriens pkriens merged commit c500b49 into bndtools:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants