Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgrade to plexus-build-api 1.1.0" #5680

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

pkriens
Copy link
Member

@pkriens pkriens commented Jun 1, 2023

This reverts commit 2443973.

The current Eclipse we're using is still based on the sonatype code base. In Eclipse, with ecj, the patch generates an error that it clearly does not do on javac/gradle.

image

image

image

  The type org.sonatype.plexus.build.incremental.BuildContext cannot be resolved. It is indirectly referenced from required type 

org.eclipse.m2e.core.project.configurator.AbstractBuildParticipant

@gnodet, can you take a look? I'd love to take it but not sure if we can do this without going to a later Eclipse?


Signed-off-by: Peter Kriens Peter.Kriens@aQute.biz

The current  Eclipse we're using is still based on the sonatype code base.

In Eclipse, with ecj, the patch generates an error that it clearly does not
do on javac/gradle.

@gnodet, can you take a look?

This reverts commit 2443973.

---
 Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
@pkriens pkriens merged commit de14b66 into bndtools:master Jun 1, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants