classfile: Properly handle unnamed MethodParameter

[bjhargrave]

A method parameter may not have a name.

Fixes #5689

[bjhargrave]

@pkriens You may want to cherry-pick this back for a 6.4.2 release.

[pkriens]

thanks for doing this man!

[jhanders34]

@pkriens Any more thoughts on getting this put into a 6.4.2 release?

[pkriens]

If I get a very good reason why 7.0.0 is not good enough?

6.4.1 is only intended for people that need runtime bundles for Java 1.8. Since this is in a library that is intended to use for development, I am not sure there is a need to have it available on Java 1.8?

[jhanders34]

We can make it work with 7.0.0 when it is available. Will still need to use the 6.x transform bundle when running Eclipse Transformer when testing Java 8 and 11.

[pkriens]

There is a 7.1.0 snapshot and a 7.0.0.RC1 right now. All Java 17

Can't you run the 1.8 and 11 code on a Java 17 VM?

[jhanders34]

We can run Java 1.8 and 11 code on a Java 17 VM, but our byte code is Java 8, 11, and 17 depending on the level of Java the feature requires. So we test Java 8 and 11 VMs for our code still because Java 8 and 11 are still supported and aren't end of life yet.

[pkriens]

Still not getting it, sorry. A release is a significant amount of work and I was hoping 6.4.1 classic would slowly die. I see this is BJ's project.

@bjhargrave if you say it is very important to have this library in Java 1.8, then I'll make another release of classic. I was thinking calling it like 180.2.0 to move it out of the 6.4 semantics, that was a mistake I realize now.

[jhanders34]

I am ok with it not moving to 6.4.2. We can wait on 7.0.0 which hopefully will be out soon. Do you know when you plan on releasing 7.0.0?