Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BndPomRepository should support both bsn and gav like MavenBndRepository #5964

Merged

Commits on Jan 11, 2024

  1. fail test showing gav is not working in BndPomRepo

    this PomRepositoryTest. testGetViaBSNAndGAV() will fail, which we try to fix in the next commit.
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    39eca3c View commit details
    Browse the repository at this point in the history
  2. pass test for GAV

    1st draft, base for discussion.
    I hooked into the indexing of BridgeRepository because commons-cli:commons-cli:1.2 (commons-cli-1.2.jar) is indexed as commons-cli:commons-cli:1.2.0 by bridge repo (notice 1.2 vs. 1.2.0). To satisfy the existing testcase of MavenBndRepo this was the only place where I could get the version as 3 digit semver. To be discussed if it really should be that way
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    dabeb36 View commit details
    Browse the repository at this point in the history
  3. fix test

    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    3e82952 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. extend test to check that 1.2.0 and 1.2 work too

    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    2ac5779 View commit details
    Browse the repository at this point in the history
  2. Revert previous commits and extend test

    This reverts commit 3e82952.
    
    Revert "pass test for GAV"
    
    This reverts commit dabeb36.
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    e721148 View commit details
    Browse the repository at this point in the history
  3. handle GAV in BndPomRepository

    * based on Peter's suggestion. Since BndPomRepository.archives and PomRepository.archives were both null when using a pom.xml (instead of revisions) I populated them in PomRepository.save(). If there is another / better way, we can change that
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    0a4fb4c View commit details
    Browse the repository at this point in the history
  4. clear list on refresh

    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    ec12e5f View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. naming

    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    968f3b0 View commit details
    Browse the repository at this point in the history
  2. extend test: versions(bsn) has the problem too

    After testing the initial problem it turned out the ${repo;gav;latest} also runs through repo.versions(gav) so we have to support it too
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    34ec26a View commit details
    Browse the repository at this point in the history
  3. support GAV in repo.versions(bsn) too

    fixes the testcase from previous commit and solves the initial reported issue with (${repo;gav;latest} not working with BndPomRepo)
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    02b1dc3 View commit details
    Browse the repository at this point in the history