Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add access artifact properties through api #6080

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

bvfalcon
Copy link
Contributor

@bvfalcon bvfalcon commented Apr 9, 2024

Closes issue #6062.

@chrisrueger
Copy link
Contributor

chrisrueger commented Apr 9, 2024

@bvfalcon thanks for your PR. Could you please sign the commit as described here?

Depends a bit on your git client. In Github Desktop it is e.g. possible via "ammend commit" and then add your sign off to the description e.g.
image
But command line works as well.

@pkriens
Copy link
Member

pkriens commented Apr 9, 2024

You need to sign the commit, see https://github.com/bndtools/bnd/pull/6080/checks?check_run_id=23608761603

Signed-off-by: Vladimir V. Bychkov <github@bychkov.name>
@pkriens
Copy link
Member

pkriens commented Apr 19, 2024

You ran in a baseline error:

/home/runner/work/bnd/bnd/biz.aQute.repository/src/aQute/p2/api/package-info.java:0: error: Baseline mismatch for package aQute.p2.api, MINOR change. Current is 1.4.0, repo is 1.4.0, suggest 1.5.0 or -
MINOR                PACKAGE    aQute.p2.api
  MINOR              CLASS      aQute.p2.api.Artifact
    ADDED            METHOD     getProperties()
      ADDED          RETURN     java.util.Map
    ADDED            METHOD     getProperty(java.lang.String)
      ADDED          RETURN     java.lang.String
    ADDED            METHOD     setProperties(java.util.Map)
      ADDED          RETURN     void

If you made the changes in Eclipse with bndtools you'd noticed this direct. You should also build before pushing because this error also shows up in the gradlew build.

Just bump the version in biz.aQute.repository/src/aQute/p2/api/package-info.java

Signed-off-by: Vladimir V. Bychkov <github@bychkov.name>
@pkriens pkriens merged commit dbcaea6 into bndtools:master Apr 22, 2024
9 checks passed
@pkriens
Copy link
Member

pkriens commented Apr 22, 2024

Next time will be a bit smoother after all the hurdles you had to jump so far :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend artifact with additional attributes
3 participants