Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for repository tags #6116

Merged
merged 13 commits into from
Jun 21, 2024

Commits on May 8, 2024

  1. allow tagging of repositories

    e.g. add a property tags="baseline,release, foo";\ to a Repository in build.bnd
    
    tags="baseline,release, foo";\
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 8, 2024
    Configuration menu
    Copy the full SHA
    52af186 View commit details
    Browse the repository at this point in the history
  2. use Set

    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 8, 2024
    Configuration menu
    Copy the full SHA
    ea7740d View commit details
    Browse the repository at this point in the history
  3. add tagged support to more repos and edit dialog

    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 8, 2024
    Configuration menu
    Copy the full SHA
    359a405 View commit details
    Browse the repository at this point in the history
  4. allow to use tag in -runrepos in .bndrun

    example:
    -runrepos: \
    	Workspace,\
    	@resolve
    
    this adds the Workspace repo and all other repos tagged with the tag 'resolve'
    
    I used the '@' character as a marker for tags (for now). initially I wanted to use '#' but this is a comment in a .bndrun file.
    
    With this i got a successful resolution as before
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 8, 2024
    Configuration menu
    Copy the full SHA
    dd36fe1 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. rework - repos now have 'resolve' tag by default

    - this commit partly reverts previous commit
    - repos now get the 'resolve' tag by default if not specified
    - .bndrun: empty -runrepos will be populated with all repos having the 'resolve' tag
    - .bndrun: resolution consider all repos having the 'resolve' tag. that means you can exclude a repo from resolution by manually assigning it a different tag (e.g. to exclude the baseline repo from resolution, you should give the baseline-repo e.g. the tag 'baseline' and make sure it does NOT have the 'resolve' tag
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b9a574f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    34091a8 View commit details
    Browse the repository at this point in the history
  2. implement suggestions

    - extend RepositoryPlugin with Tagged
    - make a Tags class, extending Set
    - not parsing the string all the time
    - replace RepoTags enum with Constants.REPOTAGS_RESOLVE
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c08cce3 View commit details
    Browse the repository at this point in the history
  3. move matchesTags back to Tagged

    Somehow I think it belongs there.
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e990f07 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Tags implement Set using an internal sorted set

    fix and improve testcase to test for consistent sorting of tags
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 20, 2024
    Configuration menu
    Copy the full SHA
    7857d51 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. improve tag matching

    - keep backwards compatibility so that Repos without tags return an empty set and empty set means "matches"
    - renamed Tags.matchesTags to Tags.isIncluded
    - move tags to own package aQute.bnd.service.tags
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 21, 2024
    Configuration menu
    Copy the full SHA
    53cb0dc View commit details
    Browse the repository at this point in the history
  2. mention <<EMPTY>> placeholderin repo plugin UI

    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e46fd43 View commit details
    Browse the repository at this point in the history
  3. make tags a combobox in Plugins UI

    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7f04909 View commit details
    Browse the repository at this point in the history
  4. rename to Tags.includesAny

    I think that better reflects the intent.
    - also adjusting javadoc accordingly
    - and move static methods to bottom
    
    Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
    chrisrueger committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7313fbc View commit details
    Browse the repository at this point in the history