This repository has been archived by the owner on Dec 9, 2018. It is now read-only.
[launching] add BndContainerRuntimeClasspathEntryResolver #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Amerson <gregory.amerson@liferay.com>
fixes bndtools#1395 fixes bndtools#1366 Signed-off-by: Gregory Amerson <gregory.amerson@liferay.com>
gamerson
force-pushed
the
classpathProvider
branch
from
37b8055
to
8a561e1
Compare
|
Basically it looks ok to me but I don't have any understanding of this part of Eclipse :-) |
|
@gamerson, should we go ahead and merge this? |
|
Sorry I haven't gotten a chance to test it fully, on all Bnd launch types (like bndrun launches, etc). I hope to have a chance to test it this week, before Friday. |
|
hey @bjhargrave I have confirmed that this new resolver introduces issues in other types of bnd launches, so I will close this for now until I can take another look at the implementation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.