-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Workspace template from OSGi R7 to R8 #24
Conversation
As suggested in bndtools/bndtools.workspace.min#11 (comment) we up this repo to OSGi R8 and base it on the files of bndtools.workspace.min initially This may not be the final solution but at least a first step to have an OSGi R8 environment, so that templates may build upon that Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
@pkriens Could you give me some intro into the templates Where does it come from? |
Since we want to remove this workspace (see bndtools/bnd#6164) and only keep https://github.com/bndtools/bndtools.workspace.min/ I am closing this. @pkriens just FYI |
@chrisrueger doesn't that mean that all <= 7.0 versions of bndtools...when using this template...will stay on OSGi R7? If so, I'm not challenging that decision...I'm just wondering if that has been explicitly discussed. |
Hi @scottslewis , As far as I understand the workspace templates, they are just a bunch of files (build.bnd + .mvn repo definitions) which are "copied" to the In bndtools/bnd#6164 I just removed this specific workspace template here from the list of available templates which is presented to you to choose from. So this template here would not be available in the list of >= 7.1. If somebody still wants to use that template I think even in
"explicitly discussed"...well.... I wouldn't put my hand in the fire for it 😄 but we could have this discussion now. Let me know |
My expectation matches all of what you say above.
Yes that was my assumption too. IMHO it might be worthwhile to put something in the documentation...e.g. in the updates file for 7.1 along the lines of what you say above...i.e. that if users wish to continue to use the bndtools.workspace template (R7) then then can easily do so as you describe. > > "explicitly discussed"...well.... I wouldn't put my hand in the fire for it 😄 but we could have this discussion now.I guess we just did. I was trying to make sure that it was clear to all what existing bndtools <7.0 users would experience (R7 from bndtools.workspace and R8 [I think] for bndtools.workspace.min), and what people transitioning from 7.0 to 7.1 would experience ('why is bndtools.workspace missing now? I just used it in 7.0'). Thanks. |
ok, great thanks for the feedback @scottslewis
I added something to the section here https://github.com/bndtools/bnd/wiki/Changes-in-7.1.0#templates |
As suggested in bndtools/bndtools.workspace.min#11 (comment) by @scottslewis we up this repo to OSGi R8 and base it on the files of bndtools.workspace.min initially
This may not be the final solution but at least a first step to have an OSGi R8 environment, so that templates may build upon that.
How to test this?
This is the place where I need support to verify if we are satisfied with result, or what needs to be changed / added.
Add this current repo to "Raw Git Clone URLs" (
https://github.com/chrisrueger/workspace.git
and branchorigin/R7-to-R8
)Click Apply and Close
Go to File / New / Bnd OSGi Workspace