Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise and this reference caused uncaught exception in openid module sendToAuthenticationUri step #287

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Commits on May 24, 2012

  1. added smarterer oauth

    kaizenpack committed May 24, 2012
    Configuration menu
    Copy the full SHA
    0b504c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2012

  1. Configuration menu
    Copy the full SHA
    be51e02 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2012

  1. Configuration menu
    Copy the full SHA
    40ef8aa View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2012

  1. Merge pull request bnoguchi#280 from jacksonp/master

    Readme Fix for Google OAuth2
    bnoguchi committed Jun 11, 2012
    Configuration menu
    Copy the full SHA
    545751c View commit details
    Browse the repository at this point in the history
  2. Merge pull request bnoguchi#275 from ebaizel/patch-2

    password was not being deleted.
    bnoguchi committed Jun 11, 2012
    Configuration menu
    Copy the full SHA
    fd7d567 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2012

  1. Configuration menu
    Copy the full SHA
    1b986b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2012

  1. added smarterer to README

    kaizenpack committed Jun 13, 2012
    Configuration menu
    Copy the full SHA
    9794626 View commit details
    Browse the repository at this point in the history
  2. added full detail section

    kaizenpack committed Jun 13, 2012
    Configuration menu
    Copy the full SHA
    ae046f3 View commit details
    Browse the repository at this point in the history
  3. fixed indentation issue

    kaizenpack committed Jun 13, 2012
    Configuration menu
    Copy the full SHA
    f792d7a View commit details
    Browse the repository at this point in the history
  4. Now using Github api v3

    hostalerye committed Jun 13, 2012
    Configuration menu
    Copy the full SHA
    be7c423 View commit details
    Browse the repository at this point in the history
  5. Merge pull request bnoguchi#281 from kaizenpack/master

    include smarterer oauth
    bnoguchi committed Jun 13, 2012
    Configuration menu
    Copy the full SHA
    784547f View commit details
    Browse the repository at this point in the history
  6. Merge pull request bnoguchi#282 from hostalerye/master

    Changed github apiHost url and fetchOAuthUser to work with github api v3
    bnoguchi committed Jun 13, 2012
    Configuration menu
    Copy the full SHA
    9f2c438 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2012

  1. 1) Openid sendToAuthenticationUri step did not provide correct Promis…

    …e object reference to use inside this.relyingParty.authenticate callback function. Also call back function did not fulfill promise and step itself did not return promise reference.
    
    2) this.redirect in this.relyingParty.authenticate callback function thrown exception because this in the context did not have redirect method. Thus self was defined in outer context and self.redirect invoked.
    genuisereal committed Jun 20, 2012
    Configuration menu
    Copy the full SHA
    e1bf208 View commit details
    Browse the repository at this point in the history
  2. minor styling

    genuisereal committed Jun 20, 2012
    Configuration menu
    Copy the full SHA
    bd8a8e8 View commit details
    Browse the repository at this point in the history
  3. Fix: after testing with non working openid provider new error issue a…

    …pperared. which led to the conclusion that added Promise does not solve the problem as long as if we analyze the initialization of the step it clearly says that no promoses are expected to be returned.
    
    
    Thus condition `if(err) return p.fail(err);` seems now incorrect. And must be removed.
    genuisereal committed Jun 20, 2012
    Configuration menu
    Copy the full SHA
    bea944b View commit details
    Browse the repository at this point in the history
  4. Minor fix

    genuisereal committed Jun 20, 2012
    Configuration menu
    Copy the full SHA
    3b894d6 View commit details
    Browse the repository at this point in the history
  5. Minor fix

    genuisereal committed Jun 20, 2012
    Configuration menu
    Copy the full SHA
    06ea58d View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2012

  1. Fix: correct error handling implemented

    Finally working solution is found. `sendToAuthenticationUri` now correctly return fulfilled promise in normal case and fails if error.
    genuisereal committed Jun 21, 2012
    Configuration menu
    Copy the full SHA
    3d60247 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3dba27 View commit details
    Browse the repository at this point in the history