New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise and this reference caused uncaught exception in openid module sendToAuthenticationUri step #287
base: master
Are you sure you want to change the base?
Commits on May 24, 2012
-
Configuration menu - View commit details
-
Copy full SHA for 0b504c9 - Browse repository at this point
Copy the full SHA 0b504c9View commit details
Commits on Jun 6, 2012
-
Configuration menu - View commit details
-
Copy full SHA for be51e02 - Browse repository at this point
Copy the full SHA be51e02View commit details
Commits on Jun 10, 2012
-
Configuration menu - View commit details
-
Copy full SHA for 40ef8aa - Browse repository at this point
Copy the full SHA 40ef8aaView commit details
Commits on Jun 11, 2012
-
Merge pull request bnoguchi#280 from jacksonp/master
Readme Fix for Google OAuth2
Configuration menu - View commit details
-
Copy full SHA for 545751c - Browse repository at this point
Copy the full SHA 545751cView commit details -
Merge pull request bnoguchi#275 from ebaizel/patch-2
password was not being deleted.
Configuration menu - View commit details
-
Copy full SHA for fd7d567 - Browse repository at this point
Copy the full SHA fd7d567View commit details
Commits on Jun 12, 2012
-
Configuration menu - View commit details
-
Copy full SHA for 1b986b6 - Browse repository at this point
Copy the full SHA 1b986b6View commit details
Commits on Jun 13, 2012
-
Configuration menu - View commit details
-
Copy full SHA for 9794626 - Browse repository at this point
Copy the full SHA 9794626View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae046f3 - Browse repository at this point
Copy the full SHA ae046f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f792d7a - Browse repository at this point
Copy the full SHA f792d7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for be7c423 - Browse repository at this point
Copy the full SHA be7c423View commit details -
Merge pull request bnoguchi#281 from kaizenpack/master
include smarterer oauth
Configuration menu - View commit details
-
Copy full SHA for 784547f - Browse repository at this point
Copy the full SHA 784547fView commit details -
Merge pull request bnoguchi#282 from hostalerye/master
Changed github apiHost url and fetchOAuthUser to work with github api v3
Configuration menu - View commit details
-
Copy full SHA for 9f2c438 - Browse repository at this point
Copy the full SHA 9f2c438View commit details
Commits on Jun 20, 2012
-
1) Openid sendToAuthenticationUri step did not provide correct Promis…
…e object reference to use inside this.relyingParty.authenticate callback function. Also call back function did not fulfill promise and step itself did not return promise reference. 2) this.redirect in this.relyingParty.authenticate callback function thrown exception because this in the context did not have redirect method. Thus self was defined in outer context and self.redirect invoked.
Configuration menu - View commit details
-
Copy full SHA for e1bf208 - Browse repository at this point
Copy the full SHA e1bf208View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd8a8e8 - Browse repository at this point
Copy the full SHA bd8a8e8View commit details -
Fix: after testing with non working openid provider new error issue a…
…pperared. which led to the conclusion that added Promise does not solve the problem as long as if we analyze the initialization of the step it clearly says that no promoses are expected to be returned. Thus condition `if(err) return p.fail(err);` seems now incorrect. And must be removed.
Configuration menu - View commit details
-
Copy full SHA for bea944b - Browse repository at this point
Copy the full SHA bea944bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b894d6 - Browse repository at this point
Copy the full SHA 3b894d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06ea58d - Browse repository at this point
Copy the full SHA 06ea58dView commit details
Commits on Jun 21, 2012
-
Fix: correct error handling implemented
Finally working solution is found. `sendToAuthenticationUri` now correctly return fulfilled promise in normal case and fails if error.
Configuration menu - View commit details
-
Copy full SHA for 3d60247 - Browse repository at this point
Copy the full SHA 3d60247View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3dba27 - Browse repository at this point
Copy the full SHA e3dba27View commit details