Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm module outdated #28

Closed
TimBeyer opened this issue Feb 12, 2014 · 3 comments
Closed

npm module outdated #28

TimBeyer opened this issue Feb 12, 2014 · 3 comments

Comments

@TimBeyer
Copy link

On npm, version 0.2.5 does not reflect the actual code in this repository.
It's still a very outdated version using HeapProfiler::TakeSnapshot instead of HeapProfiler::TakeHeapSnapshot, causing compilation errors every time I try to install it.

I guess something went wrong while publishing it.

@bnoordhuis
Copy link
Owner

The published version targets node.js v0.10 and reflects the v0.10 branch in this repository. I suspect that you're using node.js v0.11 if you're getting build errors with that release.

I haven't done any releases for v0.11 because it's a moving target, it's the development branch. Once v0.12 is released, I'll put out a new release of node-heapdump.

bnoordhuis added a commit that referenced this issue Feb 13, 2014
Apply some macro magic to make the module compile with both v0.10 and
v0.11.  It doesn't look pretty but it's fairly unobtrusive.  This also
spells the end of the v0.10 branch.

Fixes #28.
@bnoordhuis
Copy link
Owner

And then I changed my mind. I landed a horrible (but effective) hack in c6e8a07 that makes the module compile with v0.10 and v0.11. Published as v0.2.6.

@TimBeyer
Copy link
Author

That is awesome, thank you. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants