Filter out empty suite results for version (#153)

* Filter out empty suite results for version * Remove a console log
boa-dev · Apr 23, 2024 · c232f2b · c232f2b
1 parent 3842ab5
commit c232f2b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx b/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { SuiteResult } from "@site/src/components/conformance/types";
+import { SuiteResult, TestStats } from "@site/src/components/conformance/types";
 
 import styles from "./styles.module.css";
 
@@ -14,6 +14,10 @@ export default function SuiteSelector(props: SelectorProps): JSX.Element {
     <div className={styles.suiteSelector}>
       {props.suites
         .sort((a, b) => a.name.localeCompare(b.name))
+        .filter((suite) => {
+          let versionStats: TestStats = suite.versionedStats[props.esFlag];
+          return versionStats.total !== 0;
+        })
         .map((suite) => {
           return (
             <SuiteItem

diff --git a/src/components/conformance/ResultsDisplay/nav.tsx b/src/components/conformance/ResultsDisplay/nav.tsx
@@ -13,7 +13,10 @@ type ResultsNavProps = {
 export default function ResultNavigation(props: ResultsNavProps): JSX.Element {
   return (
     <div className={styles.resultsNav}>
-      <EcmaScriptVersionDropdown setEcmaScriptFlag={props.setEcmaScriptFlag} esVersionValue={props.state.ecmaScriptVersion} />
+      <EcmaScriptVersionDropdown
+        setEcmaScriptFlag={props.setEcmaScriptFlag}
+        esVersionValue={props.state.ecmaScriptVersion}
+      />
       <NavBreadCrumbs
         navPath={props.state.testPath}
         sliceNavToIndex={props.sliceNavToIndex}
@@ -79,12 +82,14 @@ type DropDownProps = {
 };
 
 function EcmaScriptVersionDropdown(props: DropDownProps): JSX.Element {
-  const [dropdownValue, setDropdownValue] = React.useState(props.esVersionValue ? props.esVersionValue : "");
+  const [dropdownValue, setDropdownValue] = React.useState(
+    props.esVersionValue ? props.esVersionValue : "",
+  );
 
   // Update the flag when props.esVersionValue is changed
-  React.useEffect(()=>{
-    setDropdownValue(props.esVersionValue)
-  }, [props.esVersionValue])
+  React.useEffect(() => {
+    setDropdownValue(props.esVersionValue);
+  }, [props.esVersionValue]);
 
   const handleVersionSelection = (e) => {
     // Update the display value and set the flag.