New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateRealm() function #119

Closed

jasonwilliams opened this issue Sep 27, 2019 · 1 comment · Fixed by #126

Labels

Member

jasonwilliams commented Sep 27, 2019

https://github.com/jasonwilliams/boa/blob/master/src/lib/exec.rs#L438-L452 should be replaced with a create_realm() function which matches up with https://tc39.es/ecma262/#sec-createrealm

jasonwilliams added the help wanted label

jasonwilliams added this to the Boa Shell milestone

jasonwilliams mentioned this issue

replacing ExecutorBuilder with Realm #126

Merged

jasonwilliams closed this as completed in #126

Member

Razican commented Nov 1, 2019

Is this done? It seems that it was mistakenly closed when committing #126, that specifically says "This doesn't fix #119"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment