Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing ExecutorBuilder with Realm #126

Merged
merged 5 commits into from
Oct 2, 2019
Merged

replacing ExecutorBuilder with Realm #126

merged 5 commits into from
Oct 2, 2019

Conversation

jasonwilliams
Copy link
Member

@jasonwilliams jasonwilliams commented Oct 1, 2019

This doesn't fix #119 but it helps with that.
We would still need to add the functionality for boa shell.

This removes InterpreterBuilder and replaces it with Realm which is to be inline with the spec

@jasonwilliams jasonwilliams added this to the Boa Shell milestone Oct 1, 2019
@github-actions
Copy link

github-actions bot commented Oct 1, 2019

Benchmark for fcd5fe6

Click to view benchmark
Test PR Benchmark Master Benchmark %
Hello World (Execution) 393.9±13.99µs 170.0±7.05µs 231.99999999999997%
Hello World (Lexer) 1169.1±46.96ns 956.1±43.62ns 122%
Hello World (Parser) 1129.1±71.75ns 1125.4±46.84ns 100%
fibonacci (Execution) 5.0±0.13ms 4.7±0.15ms 107%

@github-actions
Copy link

github-actions bot commented Oct 1, 2019

Benchmark for b0ad912

Click to view benchmark
Test PR Benchmark Master Benchmark %
Hello World (Execution) 413.3±32.51µs 181.7±5.22µs 227%
Hello World (Lexer) 1220.8±53.69ns 1100.4±39.54ns 111.00000000000001%
Hello World (Parser) 1183.9±49.38ns 1240.0±73.40ns 95%
fibonacci (Execution) 5.3±0.09ms 5.2±0.11ms 101%

@github-actions
Copy link

github-actions bot commented Oct 2, 2019

Benchmark for a2bf229

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 131.8±8.52µs undefined 100%
Hello World (Execution) 358.9±19.06µs 160.1±9.34µs 224.00000000000003%
Hello World (Lexer) 1043.5±77.47ns 963.1±58.74ns 108%
Hello World (Parser) 1035.2±64.83ns 1081.7±77.08ns 96%
fibonacci (Execution) 4.8±0.18ms 4.7±0.24ms 101%

@github-actions
Copy link

github-actions bot commented Oct 2, 2019

Benchmark for c789dec

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 149.8±2.93µs undefined 100%
Hello World (Execution) 170.7±6.03µs 178.3±4.33µs 96%
Hello World (Lexer) 1072.9±51.08ns 1014.9±35.12ns 106%
Hello World (Parser) 1297.8±42.79ns 1095.4±48.58ns 118%
fibonacci (Execution) 5.2±0.11ms 5.0±0.22ms 103%

@github-actions
Copy link

github-actions bot commented Oct 2, 2019

Benchmark for 450a3dd

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 153.8±10.71µs undefined 100%
Hello World (Execution) 180.8±8.98µs 179.2±9.98µs 101%
Hello World (Lexer) 1042.5±37.85ns 1039.6±42.21ns 100%
Hello World (Parser) 1189.8±79.77ns 1202.7±74.96ns 99%
fibonacci (Execution) 5.2±0.17ms 5.3±0.27ms 97%

@jasonwilliams jasonwilliams merged commit 1c3fea4 into master Oct 2, 2019
@Razican Razican mentioned this pull request Nov 1, 2019
@jasonwilliams jasonwilliams deleted the realm branch April 3, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateRealm() function
1 participant