-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiler no longer works with measureme 9.0.0 #839
Comments
Thanks for raising this @neeldug i thought it was just me going mad, are our dependencies not locked? How did we update to their latest? |
@jasonwilliams I think it might’ve been merged with dependabot, since profiler isn’t tested in our current test suite, perhaps we should create one? |
@wesleywiser how big of a migration is this? is there a migration guide? @neeldug do you have any errors or screenshots? |
@jasonwilliams It should be pretty easy. Here's the PR I opened to upgrade rustc: rust-lang/rust#77398 |
@jasonwilliams here's a screenshot of the original errors: , currently it's working but not associating the |
moves all OS profiling to use SerializationSink as the previous types have been deprecated Closes #839
Describe the bug
The profiler no longer functions as there was a breaking change in
measureme
from 0.8.0 to 9.0.0To Reproduce
Expected behavior
The profiler to produce a profile
The text was updated successfully, but these errors were encountered: