Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update the PR benchmarks action #1774

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Update the PR benchmarks action #1774

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25f2052
Trying the new action fixes for PR benchmarksg
Razican Jan 3, 2022
08b2cd3
Small change to trigger the action
Razican Jan 27, 2022
d7a1287
Small change to trigger benchmarks
Razican Jan 27, 2022
ec6127a
Updated the GitHub action to the new release
Razican Jan 29, 2022
a15e4ad
Fixed the cwd
Razican Jan 29, 2022
e69d80c
Updated action version
Razican Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
~/.cargo/git
~/.cargo/registry
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
- uses: boa-dev/criterion-compare-action@master
- uses: boa-dev/criterion-compare-action@v3.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for pinning the action to the version 3.0.1? We could use main to avoid having to bump the version on every new change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea behind this is to follow the nomenclature with the rest of actions. This action is now being used by more projects, not only Boa, so we should use the released versions. That way we can also develop the action in the main branch as needed, and release new versions with new features. Also, @dependabot will create PRs to update the action if we do it like this.

with:
token: ${{ secrets.GITHUB_TOKEN }}
branchName: ${{ github.base_ref }}
cwd: boa
cwd: ./boa