Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix remaining Set tests #2725

Closed
wants to merge 2 commits into from
Closed

Conversation

raskad
Copy link
Member

@raskad raskad commented Mar 23, 2023

This Pull Request changes the following:

  • Add locking for Sets during iteration. We already do this for Maps.
  • Properly implement negative zero handling for add, has and delete.
  • Refactor some Set functions and add spec comments.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Mar 23, 2023
@raskad raskad added this to the v0.17.0 milestone Mar 23, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 71,071 71,076 +5
Ignored 17,324 17,324 0
Failed 5,882 5,877 -5
Panics 14 14 0
Conformance 75.39% 75.39% +0.01%
Fixed tests (5):
test/built-ins/Set/valid-values.js [strict mode] (previously Failed)
test/built-ins/Set/valid-values.js (previously Failed)
test/built-ins/Set/prototype/forEach/iterates-values-revisits-after-delete-re-add.js [strict mode] (previously Failed)
test/built-ins/Set/prototype/forEach/iterates-values-revisits-after-delete-re-add.js (previously Failed)
test/built-ins/Set/prototype/forEach/this-strict.js [strict mode] (previously Failed)

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2725 (b229ad1) into main (9b53859) will decrease coverage by 0.06%.
The diff coverage is 65.51%.

@@            Coverage Diff             @@
##             main    #2725      +/-   ##
==========================================
- Coverage   50.45%   50.40%   -0.06%     
==========================================
  Files         395      393       -2     
  Lines       39810    39870      +60     
==========================================
+ Hits        20085    20095      +10     
- Misses      19725    19775      +50     
Impacted Files Coverage Δ
boa_engine/src/builtins/map/ordered_map.rs 76.92% <ø> (ø)
boa_engine/src/builtins/set/mod.rs 68.85% <57.35%> (-5.12%) ⬇️
boa_engine/src/builtins/set/ordered_set.rs 69.09% <73.17%> (+4.80%) ⬆️
boa_engine/src/builtins/set/set_iterator.rs 89.58% <100.00%> (ø)
boa_engine/src/object/mod.rs 31.21% <100.00%> (-0.32%) ⬇️
boa_engine/src/value/display.rs 66.41% <100.00%> (ø)

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Razican
Copy link
Member

Razican commented Mar 23, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 23, 2023
This Pull Request changes the following:

- Add locking for `Set`s during iteration. We already do this for `Map`s.
- Properly implement negative zero handling for `add`, `has` and `delete`.
- Refactor some `Set` functions and add spec comments.
@bors
Copy link

bors bot commented Mar 23, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix remaining Set tests [Merged by Bors] - Fix remaining Set tests Mar 23, 2023
@bors bors bot closed this Mar 23, 2023
@bors bors bot deleted the fix-set-tests branch March 23, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants