Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ICU4X to 1.3 #3306

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Bump ICU4X to 1.3 #3306

merged 7 commits into from
Sep 26, 2023

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Sep 25, 2023

Superseeds #3300, #3301, #3302 and #3304.
This Pull Request bumps ICU4X dependencies to v1.3.0.

This also contains several improvements within the ICU utilities enabled by the new features of ICU4X like bundled data.

@jedel1043 jedel1043 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 25, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Sep 25, 2023
@jedel1043 jedel1043 requested a review from a team September 25, 2023 15:58
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,165 75,179 +14
Ignored 19,494 19,494 0
Failed 915 901 -14
Panics 0 0 0
Conformance 78.65% 78.66% +0.01%
Fixed tests (14):
test/built-ins/String/prototype/toLocaleUpperCase/special_casing.js [strict mode] (previously Failed)
test/built-ins/String/prototype/toLocaleUpperCase/special_casing.js (previously Failed)
test/intl402/String/prototype/toLocaleLowerCase/special_casing_Lithuanian.js [strict mode] (previously Failed)
test/intl402/String/prototype/toLocaleLowerCase/special_casing_Lithuanian.js (previously Failed)
test/intl402/String/prototype/toLocaleLowerCase/special_casing_Turkish.js [strict mode] (previously Failed)
test/intl402/String/prototype/toLocaleLowerCase/special_casing_Turkish.js (previously Failed)
test/intl402/String/prototype/toLocaleLowerCase/special_casing_Azeri.js [strict mode] (previously Failed)
test/intl402/String/prototype/toLocaleLowerCase/special_casing_Azeri.js (previously Failed)
test/intl402/String/prototype/toLocaleUpperCase/special_casing_Lithuanian.js [strict mode] (previously Failed)
test/intl402/String/prototype/toLocaleUpperCase/special_casing_Lithuanian.js (previously Failed)
test/intl402/String/prototype/toLocaleUpperCase/special_casing_Turkish.js [strict mode] (previously Failed)
test/intl402/String/prototype/toLocaleUpperCase/special_casing_Turkish.js (previously Failed)
test/intl402/String/prototype/toLocaleUpperCase/special_casing_Azeri.js [strict mode] (previously Failed)
test/intl402/String/prototype/toLocaleUpperCase/special_casing_Azeri.js (previously Failed)

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (8b93ff5) 49.79% compared to head (04dec3c) 49.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3306      +/-   ##
==========================================
+ Coverage   49.79%   49.83%   +0.04%     
==========================================
  Files         441      441              
  Lines       43081    43013      -68     
==========================================
- Hits        21452    21437      -15     
+ Misses      21629    21576      -53     
Files Coverage Δ
boa_engine/src/builtins/intl/mod.rs 84.78% <ø> (ø)
boa_engine/src/builtins/map/map_iterator.rs 94.44% <ø> (ø)
boa_engine/src/builtins/set/ordered_set.rs 75.00% <100.00%> (+5.90%) ⬆️
boa_engine/src/builtins/set/set_iterator.rs 90.56% <ø> (ø)
boa_icu_provider/src/lib.rs 100.00% <ø> (ø)
boa_parser/src/lexer/identifier.rs 90.38% <100.00%> (-1.42%) ⬇️
boa_engine/src/builtins/map/ordered_map.rs 80.64% <50.00%> (+5.26%) ⬆️
boa_engine/src/builtins/intl/collator/mod.rs 5.85% <0.00%> (+0.29%) ⬆️
boa_engine/src/context/icu.rs 47.22% <63.63%> (+15.07%) ⬆️
boa_engine/src/builtins/string/mod.rs 57.33% <14.28%> (+1.30%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043
Copy link
Member Author

Pinning versions so that there are no surprises next time

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@raskad raskad added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 57604ae Sep 26, 2023
10 checks passed
@jedel1043 jedel1043 deleted the bump-icu-1.3 branch September 26, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants