Move parameter environment creation to bytecode #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
technical debt
execution
HalidOdat
force-pushed
the
refactor/arguments-creation
branch
from
8371337
to
8365701
Compare
HalidOdat
force-pushed
the
refactor/move-parameter-env-opcode
branch
from
c013d99
to
f084460
Compare
HalidOdat
force-pushed
the
refactor/arguments-creation
branch
from
8365701
to
37a333b
Compare
HalidOdat
force-pushed
the
refactor/move-parameter-env-opcode
branch
from
f084460
to
f1b57a7
Compare
HalidOdat
force-pushed
the
refactor/arguments-creation
branch
from
37a333b
to
1571404
Compare
HalidOdat
force-pushed
the
refactor/move-parameter-env-opcode
branch
from
f1b57a7
to
992b722
Compare
HalidOdat
force-pushed
the
refactor/arguments-creation
branch
from
1571404
to
ff6e79b
Compare
HalidOdat
force-pushed
the
refactor/move-parameter-env-opcode
branch
from
992b722
to
520f8c8
Compare
HalidOdat
force-pushed
the
refactor/move-parameter-env-opcode
branch
from
520f8c8
to
0c1a450
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3433 +/- ##
==========================================
- Coverage 44.83% 44.81% -0.02%
==========================================
Files 488 488
Lines 50390 50374 -16
==========================================
- Hits 22590 22575 -15
+ Misses 27800 27799 -1
☔ View full report in Codecov by Sentry. |
Test262 conformance changes
|
raskad
approved these changes
Nov 2, 2023
jedel1043
approved these changes
Nov 2, 2023
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
sam-finch-tezos
pushed a commit
to trilitech/boa
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3432
Moves parameters environments creation to bytecode, removes checks for functions that don't need it.