Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugin documentation for GameMethod #1132

Closed
kevinddchen opened this issue Feb 11, 2023 · 2 comments · Fixed by #1134
Closed

Update plugin documentation for GameMethod #1132

kevinddchen opened this issue Feb 11, 2023 · 2 comments · Fixed by #1134

Comments

@kevinddchen
Copy link
Contributor

The documentation for plugins does not include the GameMethod enum usage introduced in #980.

I think it would be useful to include, since I personally spent a very long time figuring out
1. why fnWrap was being run a second time after each move
2. why G was read-only inside fnWrap on this second call
It wasn't until I stumbled across this PR that I could reliably figure out when my moves were actually being called.
@delucis
Copy link
Member

delucis commented Feb 11, 2023

Sounds like a good idea. Would you be interested in submitting a PR based on your recent experience?

@kevinddchen
Copy link
Contributor Author

Sure! More than happy to. Ill write something, and hopefully there will be some signal in the noise I write 😆

This was referenced Feb 11, 2023
Closed
Merged
@delucis delucis linked a pull request Feb 12, 2023 that will close this issue
docs: Add docs for plugin GameMethod #1134
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Add docs for plugin GameMethod kevinddchen/boardgame.io
2 participants
@delucis @kevinddchen