Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for plugin GameMethod #1134

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

kevinddchen
Copy link
Contributor

@kevinddchen kevinddchen commented Feb 11, 2023

Minor addition to the plugin documentation, nodding at the existence of the GameMethod enum. Let me know if you want the example to be more substantial.

This PR addresses #1132.

Checklist

  • Use a separate branch in your local repo (not main).
  • Test coverage is 100% (or you have a story for why it's ok).

@delucis delucis linked an issue Feb 12, 2023 that may be closed by this pull request
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinddchen! Do you think it would be helpful to show some extra information about the GameMethod type like this?

docs/documentation/plugins.md Outdated Show resolved Hide resolved
docs/documentation/plugins.md Show resolved Hide resolved
kevinddchen and others added 2 commits February 12, 2023 08:04
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@kevinddchen
Copy link
Contributor Author

@delucis Yes, I like those changes. Thanks!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this update!

@delucis delucis changed the title Add docs for plugin GameMethod docs: Add docs for plugin GameMethod Feb 17, 2023
@delucis delucis merged commit d97ef0b into boardgameio:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plugin documentation for GameMethod
2 participants