Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve changelog isVersionBump & commitID replacement regex #1006

Merged
merged 3 commits into from Sep 13, 2021
Merged

chore: improve changelog isVersionBump & commitID replacement regex #1006

merged 3 commits into from Sep 13, 2021

Conversation

alvaromartmart
Copy link
Contributor

Minor tweaks to the regex used to detect commit id & version bump commits

Checklist

  • Use a separate branch in your local repo (not main).
  • Test coverage is 100% (or you have a story for why it's ok).

delucis
delucis requested changes Sep 10, 2021
View reviewed changes
scripts/changelog.js Outdated Show resolved Hide resolved
delucis
delucis reviewed Sep 13, 2021
View reviewed changes
scripts/changelog.js Outdated Show resolved Hide resolved
@delucis delucis merged commit e4fe528 into boardgameio:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alvaromartmart @delucis