Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update gameover metadata when null #1025

Merged
merged 3 commits into from
Oct 26, 2021
Merged

fix: Update gameover metadata when null #1025

merged 3 commits into from
Oct 26, 2021

Conversation

fladrif
Copy link
Contributor

@fladrif fladrif commented Oct 22, 2021

Checklist

  • Use a separate branch in your local repo (not main).
  • Test coverage is 100% (or you have a story for why it's ok).

delucis
delucis requested changes Oct 23, 2021
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some test coverage lacking for this change. Could we add a test for the null case?

@fladrif
Copy link
Contributor Author

fladrif commented Oct 26, 2021

Added a test to cover the null case @delucis

@delucis delucis changed the title fix: Metadata gameover update checks null fix: Update gameover metadata when null Oct 26, 2021
@delucis delucis merged commit 4301956 into boardgameio:main Oct 26, 2021
@delucis
Copy link
Member

delucis commented Oct 26, 2021

Thanks @fladrif!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fladrif @delucis