Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add node/socket debugging information #1063

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

on3iro
Copy link
Contributor

@on3iro on3iro commented Feb 27, 2022

Checklist

  • Use a separate branch in your local repo (not main).
  • Test coverage is 100% (or you have a story for why it's ok). - just made an addition to the docs ;)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@on3iro great! Thank you for this.

I have a couple of tiny suggestions to use “environment variable” over just “environment” and avoid using “simply” (in case it's not simple for some readers).

docs/documentation/debugging.md Outdated Show resolved Hide resolved
docs/documentation/debugging.md Outdated Show resolved Hide resolved
@on3iro
Copy link
Contributor Author

on3iro commented Feb 27, 2022

@on3iro great! Thank you for this.

I have a couple of tiny suggestions to use “environment variable” over just “environment” and avoid using “simply” (in case it's not simple for some readers).

@delucis great suggestions - i'll update my PR accordingly :)

@delucis delucis merged commit df1dd1b into boardgameio:main Feb 27, 2022
@delucis
Copy link
Member

delucis commented Feb 27, 2022

Thanks again for this @on3iro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants