Implement revert, use array for _prevActivePlayers & remove activePlayersDone #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes towards #445. `_prevActivePlayers` is now always an array, which will be empty unless `setActivePlayers` (or `turn.activePlayers`) is passed `{ revert: true }` at which point the previous state will be stored. If `activePlayers` becomes empty and there is something saved in `_prevActivePlayers`, the last item will be used to restore `activePlayers`.
nicolodavis
reviewed
Sep 3, 2019
| activePlayers = state.ctx._prevActivePlayers[lastIndex]; | ||
| _prevActivePlayers = state.ctx._prevActivePlayers.slice(0, lastIndex); | ||
| } else { | ||
| activePlayers = null; | ||
| _activePlayersOnce = false; |
There was a problem hiding this comment.
We should also be storing this on the stack, no?
You can have a series of setActivePlayer events that have different once: true options, and we should restore to the correct option at each revert step.
There was a problem hiding this comment.
Isn't once going away in favour of moveLimit in stages?
There was a problem hiding this comment.
Yes, that's true. Ok, feel free to leave this as is then.
nicolodavis
approved these changes
Sep 4, 2019
nicolodavis
pushed a commit
that referenced
this pull request
Sep 10, 2019
…yersDone (#449) * feat: Implement `revert` flag and use array for `_prevActivePlayers` Contributes towards #445. `_prevActivePlayers` is now always an array, which will be empty unless `setActivePlayers` (or `turn.activePlayers`) is passed `{ revert: true }` at which point the previous state will be stored. If `activePlayers` becomes empty and there is something saved in `_prevActivePlayers`, the last item will be used to restore `activePlayers`. * feat: Remove `activePlayersDone`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #445
revertflag insetActivePlayers_prevActivePlayersto an array, which stores a stack of active player valuesactivePlayersDonefromctx