Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(phases): Support setting next phase with a function #972

Merged

Conversation

jorbascrumps
Copy link
Contributor

Closes #954

I don't typically write Typescript nor have I contributed to this project in many moons so if I've missed something please let me know!

Checklist

  • Use a separate branch in your local repo (not main).
  • Test coverage is 100% (or you have a story for why it's ok).

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good, I’ve just added a couple of comments.

src/core/flow.ts Outdated Show resolved Hide resolved
src/core/flow.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/core/flow.ts Outdated Show resolved Hide resolved
@delucis delucis changed the title feat(phases): Adds support for next phase fn feat(phases): Support setting next phase with a function Aug 3, 2021
@delucis delucis merged commit 064b750 into boardgameio:main Aug 3, 2021
@delucis
Copy link
Member

delucis commented Aug 3, 2021

@jorbascrumps Nice one! Thanks.

@jorbascrumps jorbascrumps deleted the jorbascrumps/feat/phase-next-fn branch August 3, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Allow to specify next phase using a function
2 participants