Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add VS Code dev container support #986

Merged

Conversation

senritsu
Copy link
Contributor

@senritsu senritsu commented Aug 22, 2021

No changes to source files, just configuration files for dev containers. This should make it possible for anyone to just fire up the repository in a container and run it. devcontainer.json currently contains a minimum of useful extensions for linting (eslint, prettier), contributing (gitlens, github PR) and developing (React snippets).

Any suggestions for other default settings or extensions that would make development more consistent/uniform/easy?

Checklist

  • Use a separate branch in your local repo (not main).
  • Test coverage is 100%.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @senritsu! Just tried it out and seemed to work well 🙂

Just a couple of comments, but this looks good.

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
@delucis delucis changed the title senritsu/dev-container-configuration chore: Add VS Code dev container support Aug 23, 2021
@delucis delucis merged commit 1116ab0 into boardgameio:main Aug 23, 2021
@senritsu senritsu deleted the senritsu/dev-container-configuration branch August 23, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants