Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Expect Game.setup method to return G #987

Merged
merged 1 commit into from
Aug 23, 2021
Merged

fix(types): Expect Game.setup method to return G #987

merged 1 commit into from
Aug 23, 2021

Conversation

alexjurkiewicz
Copy link
Contributor

I'm fresh to this framework, so maybe I'm missing something. But this looks like a very small, simple improvement to the types 😊

Checklist

  • Use a separate branch in your local repo (not main).
  • Test coverage is 100% (or you have a story for why it's ok).

@alexjurkiewicz
Adjust Game.setup type
659593d 
The return value should be G, not any.
delucis
delucis approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nice! I actually had this queued up in another branch along with a bunch of breaking changes, but should be safe to merge this on its own. Thanks!

@delucis delucis changed the title Adjust Game.setup type fix(types): Expect Game.setup method to return G Aug 23, 2021
@delucis delucis merged commit fa30fcc into boardgameio:main Aug 23, 2021
@alexjurkiewicz alexjurkiewicz deleted the type-game-setup branch August 23, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexjurkiewicz @delucis