chore: test cases for smart contracts #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nakul1010
force-pushed
the
nakul/chore_testcases
branch
from
3393846
to
f2ef372
Compare
nakul1010
changed the title
nakul1010
changed the title
nakul1010
changed the title
nakul1010
changed the base branch from
master
to
nakul/fix_contract_docs_git_src
nakul1010
changed the base branch from
nakul/fix_contract_docs_git_src
to
master
nakul1010
changed the title
nakul1010
commented
Jan 2, 2024
nakul1010
changed the title
nakul1010
commented
Jan 2, 2024
| hex"16001493adab0a7a8cb7675db135c9c97e81942025c2c9" | ||
| ) | ||
| ); | ||
| // [FAIL. Reason: EvmError: OutOfGas] (gas: 9223372036854754743) |
There was a problem hiding this comment.
during debugging found out that, this happens because the outputLength calculations emit a huge value since the wrong output is given.
Therefore the assembly calculation here exhausts the gas.
Not sure want to handle this, as the estimated gas field will show a huge value if the inputs are wrong.
gregdhill
reviewed
Feb 6, 2024
nakul1010
force-pushed
the
nakul/chore_testcases
branch
from
bb2b5bd
to
3b1a237
Compare
nakul1010
force-pushed
the
nakul/chore_testcases
branch
from
e909f65
to
45faf2d
Compare
nakul1010
force-pushed
the
nakul/chore_testcases
branch
from
45faf2d
to
d9c4ff5
Compare
…akul/chore_testcases # Conflicts: # test/LightRelay.t.sol # test/swap/Ord_Marketplace.t.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR makes the following changes
Closes #90