Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cater for automatically detected bigrams #5

Open
bobbingwide opened this issue Jul 5, 2018 · 4 comments
Open

Cater for automatically detected bigrams #5

bobbingwide opened this issue Jul 5, 2018 · 4 comments
Assignees
Labels
enhancement Priority A High priority Severity 2 Medium severity

Comments

@bobbingwide
Copy link
Owner

In bobbingwide/bigram#4 I've added some code to automatically detect SB's in content and convert them into links.

We need to cater for situation where Genesis creates a more link which contains an SB in aria text. The pragmatic solution is to use our own more text; "more".

@bobbingwide bobbingwide added enhancement Priority A High priority Severity 2 Medium severity labels Jul 5, 2018
@bobbingwide bobbingwide self-assigned this Jul 5, 2018
@bobbingwide
Copy link
Owner Author

We should also create a 404 page that's aware of failing links.

@bobbingwide
Copy link
Owner Author

bobbingwide commented Jul 16, 2018

The code that detects SBs in context needs a few more improvements.

  1. Process SBs in Category descriptions.
  2. Detect SBs starting immediately after an HTML tag
  3. Cater for accented SBs
  4. Avoid self linking - consider using <mark>.
  5. Support local development for content being copied into Word - either produce links to the live site or just emphasis tags - so that SBs appear blue in the printed book.

@bobbingwide
Copy link
Owner Author

Also detect SBs in the Author box ... changing About bigram to Self Bio along the way.

@bobbingwide
Copy link
Owner Author

The more link needs some styling improvements. It doesn't stand out well enough as a plain link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Priority A High priority Severity 2 Medium severity
Projects
None yet
Development

No branches or pull requests

1 participant