Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bw_dash] - Update for WordPress 5.0 and the new editor #26

Closed
bobbingwide opened this issue Feb 19, 2018 · 8 comments
Closed

[bw_dash] - Update for WordPress 5.0 and the new editor #26

bobbingwide opened this issue Feb 19, 2018 · 8 comments
Assignees

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Feb 19, 2018

There may be a new editor in WordPress 5.0 that will use a number of different "dashicons" that are implemented using SVG rather than being part of the dashicons font.

Requirement

  • To be able to use [bw_dash] to display these icons.
  • To handle all the icons defined in gutenberg/components/dashicon/index.js
  • To be able to specify the displayed size.
  • Drop support for icons which don't actually exist

Future requirement

  • To use SVG icons in preference to dashicons or genericons
  • To be able to support an SVG/dashicon block
@bobbingwide bobbingwide self-assigned this Feb 19, 2018
@bobbingwide bobbingwide changed the title [bw_dash] - Update for WordPresss [bw_dash] - Update for WordPress 5.0 and the new editor Feb 19, 2018
bobbingwide added a commit that referenced this issue Mar 6, 2018
@bobbingwide
Copy link
Owner Author

bobbingwide commented Jan 6, 2019

Some of the SVG icons used for blocks no longer match the original dash icon.
If we want to use [bw_dash] to display these the code will need to be updated.
And because the SVG is more complex the logic to display the icons will need improving to cater for more than just the <path d= parameter.
First example is the archive icon.

@bobbingwide
Copy link
Owner Author

bobbingwide commented Jan 8, 2019

Couple of things.

  • The SVG for the core blocks are not the same as the original dashicons.
  • The default size for the core block icons is 24. I originally used 20 but increased it for the core/archive icon.

Proposal

  • Extend the logic to support icons for core blocks as a separate type.
  • Treat core/archive as if it were font=core. ( or class=core ? )
  • Add a new font type of core and include all the icons in the core blocks.

@bobbingwide
Copy link
Owner Author

bobbingwide commented Feb 6, 2019

Having created a separate block to display Block icons, I can now undo the changes to the SVG version of the archive icon. We'll keep the size at 24 pixels.

@bobbingwide
Copy link
Owner Author

There are probably some new dashicons that we should be able to display

@bobbingwide
Copy link
Owner Author

There are probably some new dashicons that we should be able to display

Yes there are. These were not included in v1.34.0 I’ll leave the issue open.

@bobbingwide
Copy link
Owner Author

There are probably some new dashicons that we should be able to display

Having reworked the [bw_dash] shortcode to use the new list of SVG's available in WordPress's dash icons, icons and social links there are now over 600 SVG icons that can potentially be displayed. This is in addition to the Block icons!

The logic does not yet support the display of these SVG icons.
See also #46

@bobbingwide
Copy link
Owner Author

bobbingwide commented Mar 9, 2022

I need to complete the documentation update for the 70 or so new icons in the dashicons set.
And mention the 280 or so WordPress icons.
Note: This excludes the Social links icons which aren't yet supported by the Icon control.

@bobbingwide
Copy link
Owner Author

Closing this now that the Dashicon block supports over 580 SVG icons; some dashicons, others WordPress/Gutenberg icons.
Delivered in v2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant