Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support update from Github #10

Closed
bobbingwide opened this issue Dec 4, 2015 · 5 comments
Closed

Support update from Github #10

bobbingwide opened this issue Dec 4, 2015 · 5 comments

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Dec 4, 2015

Like many other plugins and themes the oik base plugin includes logic to allow a plugin or theme to be updated from a repository other than WordPress. For plugins which are a) delivered from an oik-plugins server, and b) already dependent on some part of oik, this logic is enabled through oik_register_plugin_server().

You can also manually enable this logic using http://www.oik-plugins.com/wordpress-plugins-from-oik-plugins/oik-base-plugin/oik-options/oik-options-plugins/oik-options-plugins-add-plugin/

Currently the plugin server has to be running the oik-plugins server logic.

We have a new requirement to be able to update the plugin from a github repository.

Proposed solution

  • Allow the "server" to be specified as a github repository e.g. https://github/bobbingwide/bbboing
  • The plugin update logic will detect this and direct requests to check for updates from github
  • It may have to fetch the .zip file directly from github and perform post processing before the plugin can be successfully installed.

There are multiple stages to this development.

The solution may enable 'local' zip files to be installed, allowing optional/recommended plugins to be delivered as part of another plugin/theme.

@bobbingwide
Copy link
Owner Author

Need to look at https://github.com/afragen/github-updater 's solution

@bobbingwide
Copy link
Owner Author

bobbingwide commented Jan 9, 2019

If the local plugin is a Git repository... which is already detectable... then shouldn’t it be possible to simply perform a pull? It assumes the server has the authority to run git stuff.

I'll write some test code in oik-batch to do some git capability checking and display a box in the oik options page using a similar technique to that which oik-css uses.

@bobbingwide
Copy link
Owner Author

Those logic to support update from a Github repo was added in
bobbingwide/oik-batch#34.
A new issue has been raised to allow a component to be added from a github repo.
bobbingwide/oik-batch#35.

@bobbingwide
Copy link
Owner Author

bobbingwide commented Dec 25, 2019

As previously stated an update from GitHub solution was implemented in bobbingwide/oik-batch#34. The other issue ( 35 ) hasn’t been addressed.

@bobbingwide
Copy link
Owner Author

I'm going to close this issue in oik as the solution is available in oik-batch.
Also, wordpress.org may not like this logic being included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant